Skip to content

BUG: DatetimeIndex.to_frame does not drop timezone information #25811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

mroeschke
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #25811 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25811      +/-   ##
==========================================
+ Coverage   91.27%   91.27%   +<.01%     
==========================================
  Files         173      173              
  Lines       53002    53002              
==========================================
+ Hits        48375    48376       +1     
+ Misses       4627     4626       -1
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.76% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.57% <100%> (ø) ⬆️
pandas/util/testing.py 89.4% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2523...110e9d9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #25811 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25811      +/-   ##
==========================================
+ Coverage   91.27%   91.27%   +<.01%     
==========================================
  Files         173      173              
  Lines       53002    53002              
==========================================
+ Hits        48375    48376       +1     
+ Misses       4627     4626       -1
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.76% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.57% <100%> (ø) ⬆️
pandas/util/testing.py 89.4% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2523...110e9d9. Read the comment docs.

@WillAyd WillAyd added Datetime Datetime data dtype Index Related to the Index class or subclasses labels Mar 21, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 21, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@jreback jreback merged commit 0bf9f14 into pandas-dev:master Mar 21, 2019
@jreback
Copy link
Contributor

jreback commented Mar 21, 2019

thanks @mroeschke nice as usual!

@mroeschke mroeschke deleted the timezone_to_frame branch March 21, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTimeIndex.to_frame() drops timezone in pandas 0.24
3 participants