Skip to content

Fix broken link to contributing guide website #26369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix broken link to contributing guide website #26369

merged 1 commit into from
May 13, 2019

Conversation

bharatr21
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@bharatr21
Copy link
Contributor Author

It's not broken per se, but why the unnecessary redirect?

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26369 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26369      +/-   ##
==========================================
- Coverage   91.68%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50700    50700              
==========================================
- Hits        46486    46482       -4     
- Misses       4214     4218       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.19% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48d1ff...bc84add. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26369 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26369      +/-   ##
==========================================
- Coverage   91.68%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50700    50700              
==========================================
- Hits        46486    46482       -4     
- Misses       4214     4218       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.19% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48d1ff...bc84add. Read the comment docs.

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone May 13, 2019
@TomAugspurger
Copy link
Contributor

Thanks @Bharat123rox. CI failures are being addressed in #26361.

@TomAugspurger TomAugspurger merged commit e26aa00 into pandas-dev:master May 13, 2019
@bharatr21 bharatr21 deleted the patch-1 branch May 14, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants