Skip to content

ASV: remove large IntervalIndex benchmark #26712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

TomAugspurger
Copy link
Contributor

Closes #26709

The setup for that N took 30s+ on my machine. I doubt that was intended.

@TomAugspurger TomAugspurger added the Performance Memory or execution speed performance label Jun 7, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix @TomAugspurger

@TomAugspurger
Copy link
Contributor Author

Hmm travis is not happy. Any objections to me merging this, and following up with CI fixes for travis?

@datapythonista
Copy link
Member

@TomAugspurger a travis build failed, but can't see how to re-run (I used to do it, not sure if travis changed something)

I also see that the doc build is failing, I'm taking a look, it was failing because this PR

@datapythonista
Copy link
Member

I'd say that the job failed because the pytest processes were killed, looks like a server problem to me.

Happy to get this merged as it is.

@TomAugspurger TomAugspurger merged commit 9a67ff4 into pandas-dev:master Jun 7, 2019
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 7, 2019
@TomAugspurger TomAugspurger deleted the 26709-intersection branch June 7, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken benchmarks
2 participants