Skip to content

CLN: compat.to_str -> core.dtypes.common.ensure_str #26811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

topper-123
Copy link
Contributor

compat.to_str is useful to have in cases where an object might be a bytes object, so it's moved to core.dtypes.common and renamed to ensure_str.

@topper-123 topper-123 force-pushed the move_compat.to_str_to_core.dtypes.common branch from 7ba9c98 to ea611fd Compare June 12, 2019 14:18
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26811 into master will decrease coverage by 50.57%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26811       +/-   ##
===========================================
- Coverage   91.76%   41.19%   -50.58%     
===========================================
  Files         178      178               
  Lines       50751    50749        -2     
===========================================
- Hits        46574    20907    -25667     
- Misses       4177    29842    +25665
Flag Coverage Δ
#multiple ?
#single 41.19% <30.76%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92% <ø> (-1.55%) ⬇️
pandas/core/dtypes/cast.py 48.5% <0%> (-42.05%) ⬇️
pandas/core/dtypes/common.py 68.99% <28.57%> (-27.29%) ⬇️
pandas/core/generic.py 38.33% <33.33%> (-55.78%) ⬇️
pandas/io/json/json.py 61.91% <50%> (-31.33%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/plotting/_matplotlib/__init__.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff488a...ea611fd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26811 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26811      +/-   ##
==========================================
- Coverage   91.76%   91.75%   -0.02%     
==========================================
  Files         178      178              
  Lines       50751    50749       -2     
==========================================
- Hits        46574    46567       -7     
- Misses       4177     4182       +5
Flag Coverage Δ
#multiple 90.35% <100%> (-0.01%) ⬇️
#single 41.2% <30.76%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92% <ø> (-1.55%) ⬇️
pandas/io/json/json.py 93.22% <100%> (-0.02%) ⬇️
pandas/core/dtypes/cast.py 90.53% <100%> (-0.02%) ⬇️
pandas/core/dtypes/common.py 96.35% <100%> (+0.06%) ⬆️
pandas/core/generic.py 94.1% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff488a...ea611fd. Read the comment docs.

@jreback jreback added the Clean label Jun 12, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 12, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@topper-123 topper-123 merged commit 2143c24 into pandas-dev:master Jun 12, 2019
@topper-123 topper-123 deleted the move_compat.to_str_to_core.dtypes.common branch June 12, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants