BUG: fix KeyError with list of a single, missing, element #27154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
added
Indexing
|
|
||
| # ... even when none is found: | ||
| expected = df.iloc[[]] | ||
| for l in [2], [2, 3]: # GH 27148 |
There was a problem hiding this comment.
better to use parametrisation than a for loop.
There was a problem hiding this comment.
I agree here, would be nice to parameterize this, easier to grok; no big deal to copy-paste the setup (no fixture really needed here)
toobaz
force-pushed
the
single_missing_item_list_27148
branch
from
c8f308b to
bbf761c
Compare
toobaz
force-pushed
the
single_missing_item_list_27148
branch
from
bbf761c to
e29d261
Compare
| expected = Series([0, 3, 6], index=MultiIndex.from_product( | ||
| [['A', 'B', 'C'], ['foo']], names=['one', 'two'])).sort_index() | ||
| elif level == -1: | ||
| # Empty: use idx[:0] as index to have appropriate (hidden) labels | ||
| expected = Series([], index=idx[:0], dtype='int64') |
There was a problem hiding this comment.
i think this is the same as the expected = s.iloc[[]] above.
with the exception case now removed, I think that this whole test could be simplified..
@pytest.mark.parametrize('indexer, expected', [
([], []), # empty ok
(['A'], slice(3)),
(['A', 'D'], slice(3)),
(['D', 'E'], []), # no values found - fine
(['D'], []), # same, with single item list: GH 27148
(pd.IndexSlice[:, ['foo']], slice(2, None, 3)),
(pd.IndexSlice[:, ['foo', 'bah']], slice(2, None, 3))
])
def test_loc_getitem_duplicates_multiindex_missing_indexers(indexer, expected):
# GH 7866
# multi-index slicing with missing indexers
idx = MultiIndex.from_product([['A', 'B', 'C'],
['foo', 'bar', 'baz']],
names=['one', 'two'])
s = Series(np.arange(9, dtype='int64'), index=idx).sort_index()
expected = s.iloc[expected]
result = s.loc[indexer]
tm.assert_series_equal(result, expected)There was a problem hiding this comment.
Right, thanks! I only changed the name of the second parameter to "pos".
toobaz
force-pushed
the
single_missing_item_list_27148
branch
3 times, most recently
from
7e37361 to
bf24e69
Compare
toobaz
force-pushed
the
single_missing_item_list_27148
branch
from
bf24e69 to
999b3e3
Compare
|
thanks @toobaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff