BUG: fix to_timestamp out_of_bounds #27916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,9 +30,6 @@ def test_asfreq_near_zero_weekly(self): | |||
| assert week1.asfreq("D", "E") >= per1 | |||
| assert week2.asfreq("D", "S") <= per2 | |||
|
|
|||
| @pytest.mark.xfail( | |||
| reason="GH#19643 period_helper asfreq functions fail to check for overflows" | |||
| ) | |||
| def test_to_timestamp_out_of_bounds(self): | |||
| # GH#19643, currently gives Timestamp('1754-08-30 22:43:41.128654848') | |||
There was a problem hiding this comment.
you can remove this comment as well I think?
jreback
added
Compat
jreback
requested changes
Aug 15, 2019
|
added whatsnew, found this also fixes the analogous bug in PeriodIndex, need to add test for that |
|
updated with additional test |
|
@jorisvandenbossche gentle ping |
|
Thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 20, 2019
jorisvandenbossche
pushed a commit
that referenced
this pull request
Aug 20, 2019
galuhsahid
pushed a commit
to galuhsahid/pandas
that referenced
this pull request
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff