TST: new test for incorrect series assignment #29378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
Testing
ganevgv
force-pushed
the
tests/series_incorrect_assignment_test
branch
from
de39ac0 to
2f0fa1e
Compare
mroeschke
approved these changes
Nov 3, 2019
jreback
requested changes
Nov 4, 2019
| @@ -391,6 +391,22 @@ def test_setslice(datetime_series): | |||
| assert sl.index.is_unique is True | |||
|
|
|||
|
|
|||
| def test_incorrect_assigment(): | |||
There was a problem hiding this comment.
can you change this test name to be more informative, something like
test_error_raised_on_2d_to_1d
There was a problem hiding this comment.
Thanks for the feedback @jreback! Changed the test name to test_2d_to_1d_assignment_error_raised.
ganevgv
force-pushed
the
tests/series_incorrect_assignment_test
branch
from
b7c2ab3 to
76cd061
Compare
There was a problem hiding this comment.
@ganevgv minor nit. test name should end with _raises for consistency with other tests. otherwise lgtm.
Co-Authored-By: Simon Hawkins <[email protected]>
|
Thanks @ganevgv! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
* add incorrect series assignment * add incorrect series assignment * passes git diff upstream * change test name * change name test Co-Authored-By: Simon Hawkins <[email protected]>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* add incorrect series assignment * add incorrect series assignment * passes git diff upstream * change test name * change name test Co-Authored-By: Simon Hawkins <[email protected]>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* add incorrect series assignment * add incorrect series assignment * passes git diff upstream * change test name * change name test Co-Authored-By: Simon Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff