TYP: Annotated pandas/core/indexing.py #29908
Conversation
gfyoung
added
Indexing
| return True | ||
|
|
||
| def _has_valid_positional_setitem_indexer(self, indexer): | ||
| def _has_valid_positional_setitem_indexer(self, indexer) -> bool: |
There was a problem hiding this comment.
it looks like this always either raises or returns True; is that accurate? if so, maybe get rid of the return value altogether (might need to update usages)
There was a problem hiding this comment.
I don't feel confident enough in reformatting this function, I'll leave it for someone else who will probably won't break the package.
|
|
||
|
|
||
| def _can_do_equal_len(labels, value, plane_indexer, lplane_indexer, obj): | ||
| def _can_do_equal_len(labels, value, plane_indexer, lplane_indexer, obj) -> bool: |
There was a problem hiding this comment.
can any of the args here be typed?
|
|
||
|
|
||
| def need_slice(obj): | ||
| def need_slice(obj) -> bool: |
There was a problem hiding this comment.
seems like obj will be a slice?
There was a problem hiding this comment.
lgtm. I think additional types as proposed by @jbrockmendel would be nice if not too much extra effort
The problem is that I don't know how to annotate them:( |
|
OK thanks @MomIsBestFriend . Sure can always add more types as you get more familiar with code base |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff