Skip to content

Conversation

proost
Copy link
Contributor

@proost proost commented Dec 13, 2019

I'm not good at English. So if there are wrong sentences or awkward sentences, please let me know.

@proost proost changed the title DOC: .get_slice_bound in MultiIndex needs documentation. (#29967) DOC: .get_slice_bound in MultiIndex needs documentation. Dec 13, 2019
@WillAyd WillAyd added Docs Typing type annotations, mypy/pyright type checking labels Dec 13, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 13, 2019
@proost proost force-pushed the doc-multiindex-get_slice_bound branch 2 times, most recently from 9652745 to 52c9ef9 Compare December 14, 2019 04:34
@pep8speaks
Copy link

pep8speaks commented Dec 14, 2019

Hello @proost! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-23 09:43:50 UTC

@proost proost force-pushed the doc-multiindex-get_slice_bound branch from 52c9ef9 to 6a3e7f7 Compare December 14, 2019 04:36
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment otherwise lgtm

@proost proost force-pushed the doc-multiindex-get_slice_bound branch 3 times, most recently from 6764191 to ae57438 Compare December 17, 2019 04:35
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonjayhawkins care to take a look?

@proost proost force-pushed the doc-multiindex-get_slice_bound branch 2 times, most recently from 69de681 to dcbbbf3 Compare December 18, 2019 04:47
@proost proost force-pushed the doc-multiindex-get_slice_bound branch 8 times, most recently from c230ddd to 08c7b6b Compare December 19, 2019 16:48
@proost proost force-pushed the doc-multiindex-get_slice_bound branch from 08c7b6b to de298f5 Compare December 19, 2019 17:49
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. if you can fix up merge conflict ping on green

@proost proost force-pushed the doc-multiindex-get_slice_bound branch from 4cce86d to de298f5 Compare December 23, 2019 09:41
@jreback jreback merged commit 56b6561 into pandas-dev:master Jan 1, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

thanks @proost

@proost proost deleted the doc-multiindex-get_slice_bound branch June 17, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: .get_slice_bound in MultiIndex needs documentation.
4 participants