Skip to content

REF: de-privatize io.common functions used elsewhere #30368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2019
Merged

REF: de-privatize io.common functions used elsewhere #30368

merged 2 commits into from
Dec 20, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added the Refactor Internal refactoring of code label Dec 20, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 20, 2019
jreback
jreback approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. needs a rebase. merge on green.

@jbrockmendel jbrockmendel merged commit 0df8858 into pandas-dev:master Dec 20, 2019
@jbrockmendel jbrockmendel deleted the cln-io-private branch December 20, 2019 17:45
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@jbrockmendel @AlexKirko
de-privatize io.common functions (pandas-dev#30368)
2e4617a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins