DOC: fix external links + favicon #30389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,7 +232,7 @@ | |||
| # The name of an image file (within the static path) to use as favicon of the | |||
| # docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32 | |||
| # pixels large. | |||
| html_favicon = os.path.join(html_static_path[0], "favicon.ico") | |||
There was a problem hiding this comment.
html_static_path is now not used. could remove?
There was a problem hiding this comment.
It might still be used by sphinx, not fully sure.
There was a problem hiding this comment.
The docs don't suggest this is the default value (https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_static_path), and we for sure still use this (there are a lot of files in the _static directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrong external links (see pydata/pydata-sphinx-theme#66), and also fixes the favicon