Skip to content

TYP: check_untyped_defs astype_nansafe #30548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2019
Merged

TYP: check_untyped_defs astype_nansafe #30548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/arrays/boolean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ def astype(self, dtype, copy=True):
na_value = np.nan
# coerce
data = self._coerce_to_ndarray(na_value=na_value)
return astype_nansafe(data, dtype, copy=None)
return astype_nansafe(data, dtype, copy=False)

def value_counts(self, dropna=True):
"""
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def astype(self, dtype, copy=True):

# coerce
data = self._coerce_to_ndarray()
return astype_nansafe(data, dtype, copy=None)
return astype_nansafe(data, dtype, copy=False)

@property
def _ndarray_values(self) -> np.ndarray:
Expand Down
6 changes: 0 additions & 6 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,9 @@ ignore_errors=True
[mypy-pandas._version]
check_untyped_defs=False

[mypy-pandas.core.arrays.boolean]
check_untyped_defs=False

[mypy-pandas.core.arrays.categorical]
check_untyped_defs=False

[mypy-pandas.core.arrays.integer]
check_untyped_defs=False

[mypy-pandas.core.arrays.interval]
check_untyped_defs=False

Expand Down