-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: assorted cleanups #30575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CLN: assorted cleanups #30575
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8ba1bfd
GH ref for 30460
jbrockmendel e3f453f
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel ba3488c
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel c0e7ec5
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 1484065
whatsnew for 29853
jbrockmendel 8ff540c
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 148dd14
remove validate_cmpress
jbrockmendel 5f945ef
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 580d66c
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 5814a4c
remove defunct comment
jbrockmendel 93ba887
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 79e83fc
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 5eb2772
annotate getattr
jbrockmendel b74b501
annotations
jbrockmendel 8690600
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel fe1237f
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel e70b940
revert bc mypy doesnt know about warnings.warn
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -472,9 +472,9 @@ def _get_result_dim(self) -> int: | |
else: | ||
return self.objs[0].ndim | ||
|
||
def _get_new_axes(self): | ||
def _get_new_axes(self) -> List[Index]: | ||
ndim = self._get_result_dim() | ||
new_axes = [None] * ndim | ||
new_axes: List = [None] * ndim | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add type parameters at some point. xref #30539 |
||
|
||
for i in range(ndim): | ||
if i == self.axis: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is #30460, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes