TST: Split test_offsets.py - Added fixtures for date offsets and business date offsets #31034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
added
the
Testing
jreback
requested changes
Jan 26, 2020
| if issubclass(getattr(offsets, o), offsets.MonthOffset) and o != "MonthOffset" | ||
| ] | ||
| ) | ||
| def date_month_classes(request): |
There was a problem hiding this comment.
this seems to duplicate month_classes no? I like your name better, can you remove the other one (and change to use this one)
| "FY5253Quarter", | ||
| "FY5253", | ||
| } | ||
|
|
There was a problem hiding this comment.
can you define offset_types in terms of the lists above?
There was a problem hiding this comment.
Sorry but I'm off due to my exams. I'll be back within a few days 😉
|
@Raalsky still active? Can you address above comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of #30194 and #31031
Second part with added (bussiness-)date offsets fixtures
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff