Skip to content

DOC fix *_option() docstring #31571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Conversation

glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Feb 2, 2020

@glemaitre glemaitre changed the title DOC fix *_option() docstring [WIP] DOC fix *_option() docstring Feb 2, 2020
@glemaitre
Copy link
Contributor Author

Is there any way to see the artefacts of the documentation built?

@glemaitre glemaitre changed the title [WIP] DOC fix *_option() docstring DOC fix *_option() docstring Feb 2, 2020
@glemaitre
Copy link
Contributor Author

Do we want a non-regression test for this?

@alimcmaster1
Copy link
Member

Is there any way to see the artefacts of the documentation built?

Yes you can build the documentation locally. See https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#building-the-documentation

@alimcmaster1
Copy link
Member

Is there any way to see the artefacts of the documentation built?

Yes probably if not too much work

@glemaitre
Copy link
Contributor Author

glemaitre commented Feb 2, 2020

Yes you can build the documentation locally. See https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#building-the-documentation

I was more referring to the artefacts stored by the CIs. I wanted to not build the documentation locally :)

@glemaitre
Copy link
Contributor Author

Yes probably if not too much work

I assume that you are referring to the unit test. I mentioning this because supposedly, you already have the numpydoc validation which is running (but not catching this one). It might be better to contribute upstream this case than just adding a single brittle test, isn't it?

@alimcmaster1
Copy link
Member

Yes you can build the documentation locally. See https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#building-the-documentation

I was more referring to the artefacts stored by the CIs. I wanted to not build the documentation locally :)

Gotcha yeah sadly we don't (to my knowledge) create any docs artefacts in azure for PRs.
We easily could though: https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/pipeline-artifacts?view=azure-devops&tabs=yaml. I usually just build locally and show the output in my PR :)

@glemaitre
Copy link
Contributor Author

I build locally for the pd.*_option and it solves the issue (kudos for being able to build a single function :))

@jorisvandenbossche jorisvandenbossche added this to the 1.0.1 milestone Feb 3, 2020
@jorisvandenbossche jorisvandenbossche merged commit abab307 into pandas-dev:master Feb 3, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 3, 2020
jorisvandenbossche pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: wrong formatting of the set_option docs
3 participants