BUG: Index(categorical, dtype=object) not returning object dtype #32167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2020
gfyoung
reviewed
Feb 22, 2020
pandas/tests/indexes/test_base.py
Outdated
| @@ -387,6 +387,12 @@ def test_constructor_dtypes_to_object(self, cast_index, vals): | |||
| assert isinstance(index, Index) | |||
| assert index.dtype == object | |||
|
|
|||
| def test_constructor_categorical_to_object(self): | |||
| # Categorical data and dtype=object should return object-dtype | |||
There was a problem hiding this comment.
Reference PR number in the comment.
|
lgtm. rebase and ping on green. |
|
let's rebase this (as merged other 2 PRs) |
|
rebased+green |
|
thanks |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIn master we get a
CategoricalIndexback.Fixing this turns out to be pre-requisite to fixing a bug in
CategoricalDtype._from_values_or_dtype, which in turn is needed to simplify the CategoricalIndex constructors (xref #32141)