CLN: Some code cleanups #32176
Merged
CLN: Some code cleanups #32176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @MomIsBestFriend |
|
|
||
| cdef dict timedelta_abbrevs = { | ||
| "Y": "Y", | ||
| "y": "Y", |
There was a problem hiding this comment.
@MomIsBestFriend possible follow-up: Y, y, M are not actually supported anymore
| """ | ||
| Replace the values in the array with 'replacement' if | ||
| they are 'nan_rep'. Return the same array. | ||
| """ | ||
| cdef: | ||
| Py_ssize_t length = len(arr), i = 0 | ||
|
|
||
| if replace is None: | ||
| replace = np.nan | ||
|
|
There was a problem hiding this comment.
this changes behavior if the user passes None here. Do we care about that?
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff