TST: move misplaced to_datetime test #32273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Feb 27, 2020
WillAyd
requested changes
Feb 27, 2020
| @@ -1376,6 +1376,86 @@ def test_to_datetime_errors_ignore_utc_true(self): | |||
| expected = DatetimeIndex(["1970-01-01 00:00:01"], tz="UTC") | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
| # TODO: this is moved from tests.series.test_timeseries, may be redundant | |||
There was a problem hiding this comment.
Is this actually redundant? If so I think should just clean up as part of this instead of comment
There was a problem hiding this comment.
at the very least it needs to be split up, but @simonjayhawkins requested that splitting be done in separate steps, which I agreed to
There was a problem hiding this comment.
this is a common issue with moving tests, moving and refactoring/cleaning together is more difficult to review and check blame in the future. so atomic commits are good and just moving is fine.
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.