-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: GroupBy(..., as_index=True).agg() drops index #33098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, a couple of comments, ping on green.
Mind merging master? Failing test should be fixed |
…641_add_test � Conflicts: � pandas/tests/groupby/test_categorical.py
Merge master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, can you merge master and ping on green. |
thanks @phofl |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
While searching for related issue for my other pull request, I found that this issue must have been fixed with another commit in the past (don't know when this issue was fixed).
I added a test to ensure that this error won't know occur in the future.