Skip to content

REF: Simplify __getitem__ by doing positional-int check first #33471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

REF: Simplify __getitem__ by doing positional-int check first #33471

merged 1 commit into from
Apr 12, 2020

Conversation

jbrockmendel
Copy link
Member

This gets rid of the last non-test usage of Index.get_value, so that can be deprecated, xref #19728

This focuses only on __getitem__; __setitem__ is tougher for a few reasons, including #33469.

@jbrockmendel jbrockmendel reopened this Apr 11, 2020
@gfyoung gfyoung added Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 12, 2020
@jreback jreback added this to the 1.1 milestone Apr 12, 2020
@jreback jreback merged commit a448b97 into pandas-dev:master Apr 12, 2020
@jreback
Copy link
Contributor

jreback commented Apr 12, 2020

thanks

@jbrockmendel jbrockmendel deleted the fallback-first branch April 12, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gfyoung gfyoung gfyoung approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung