Issue 33428 fix #33583
Closed
Issue 33428 fix #33583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a6fde1.
|
Hello @Dxin-code! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Thanks @Dxin-code for the PR. #33428 is already fixed? issue is closed. |
simonjayhawkins
requested changes
Apr 16, 2020
| @@ -219,7 +219,7 @@ def test_frame_equal_unicode(df1, df2, msg, by_blocks_fixture, obj_fixture): | |||
| # | |||
| # Test ensures that `tm.assert_frame_equals` raises the right exception | |||
| # when comparing DataFrames containing differing unicode objects. | |||
| msg = msg.format(obj=obj_fixture) | |||
| msg = f"{obj_fixture}" | |||
There was a problem hiding this comment.
please revert this change in this PR. this change is also included in #33582?
There was a problem hiding this comment.
The other edit fails the linter because the line is too long. i think close this and focus on the other PRs
|
Thanks for the PR but looks like this was already solved in #33099 |
Got it! Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff