Skip to content

Stratified sampling #33762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

flaboss
Copy link

@flaboss flaboss commented Apr 24, 2020

  • Added new method stratified_sample
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@flaboss flaboss closed this Apr 24, 2020
@flaboss flaboss reopened this Apr 24, 2020
.. _whatsnew_104.stratified_sample:

Stratified Sampling in Pandas
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a new feature, it would go in 1.1

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular Github issue where this feature is discussed?

Typically new features should be discussed in the Github issue with the core team + the community first.

@flaboss
Copy link
Author

flaboss commented Apr 24, 2020

Is there a particular Github issue where this feature is discussed?

Typically new features should be discussed in the Github issue with the core team + the community first.

Hi,
No, there is no github issue open for stratified sampling (or at least none
that I have found).
Reading the pandas documentation on contributing to the code, I found that
I could submit an enhancement. I thought of adding this method that
performs a stratified sampling, since there is no method that does that in
pandas.

If I have to open this discussion, how can I do so? I think users can
benefit from this method.

Thanks in advance.

@mroeschke
Copy link
Member

In the Issues tab, you can click the green New Issue and it will direct you to create a Feature Request that will create an issue that everyone can discuss

@flaboss
Copy link
Author

flaboss commented Apr 24, 2020

In the Issues tab, you can click the green New Issue and it will direct you to create a Feature Request that will create an issue that everyone can discuss

Great, I will do that. Thanks!

@flaboss
Copy link
Author

flaboss commented Apr 24, 2020

In the Issues tab, you can click the green New Issue and it will direct you to create a Feature Request that will create an issue that everyone can discuss

Issue #33777

@mroeschke
Copy link
Member

Thanks for your contribution, but we would rather move forward with an API that is similar to #31775

@mroeschke mroeschke closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants