Backport PR #34667 on branch 1.0.x (BLD: pyproject.toml for Py38) #34786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested changes
Jun 15, 2020
pyproject.toml
Outdated
| @@ -7,8 +7,12 @@ requires = [ | |||
| "Cython>=0.29.13", # Note: sync with setup.py | |||
| "numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'", | |||
| "numpy==1.14.5; python_version>='3.7' and platform_system!='AIX'", | |||
| "numpy==1.15.4; python_version=='3.6' and platform_system!='AIX'", | |||
| "numpy==1.15.4; python_version=='3.7' and platform_system!='AIX'", | |||
There was a problem hiding this comment.
you can remove those two lines, it's duplicating from above, and was only introduced because on master we dropped support for numpy < 1.15, but we didn't do that on 1.0.x
There was a problem hiding this comment.
and the previous line changed to == from >=
jorisvandenbossche
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #34667
@jorisvandenbossche another set of eyes needed as this was not a clean cherry-pick