Skip to content

HDFStore append_to_multiple with min_itemsize #34939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jun 22, 2020

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you add a whatsnew note in bug fixes I/O section for 1.1, ping on green.

@jreback jreback added Bug IO HDF5 read_hdf, HDFStore Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jun 24, 2020
@jreback jreback added this to the 1.1 milestone Jun 24, 2020
@fangchenli fangchenli requested a review from jreback June 24, 2020 23:48
@jreback jreback merged commit 370ddc6 into pandas-dev:master Jun 25, 2020
@jreback
Copy link
Contributor

jreback commented Jun 25, 2020

thanks @VirosaLi very nice

@fangchenli fangchenli deleted the HDFStore-append_to_multiple-min_itemsize branch June 25, 2020 23:07
fangchenli added a commit to fangchenli/pandas that referenced this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO HDF5 read_hdf, HDFStore Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

column-specific min_itemsize doesn't work with append_to_multiple
2 participants