BUG: Raise ValueError instead of bare Exception in sanitize_array #35769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
added
Constructors
|
@micahjsmith Can you add a note in /doc/source/whatsnew/v1.2.0.rst (you can reference v1.1.0.rst for notes on similar changes) and also a test for the error type / message? |
|
@dsaxton sure, working on this now |
|
@micahjsmith ping when this is updated, also see if you can track down an update any tests that just test for this raising Exception (and not ValueError). |
|
this is hit in tests.series.test_constructors.TestSeriesConstructors.test_constructor |
|
@micahjsmith can you update the appropriate test |
|
@jreback @jbrockmendel updated -- sorry for the delay. |
dsaxton
reviewed
Sep 24, 2020
|
@micahjsmith can you merge master and ping on green |
|
thanks @micahjsmith |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 10, 2020
jreback
pushed a commit
that referenced
this pull request
Oct 11, 2020
* REF/TYP: use OpsMixin for arithmetic methods * REF: separate arith_method_FRAME from flex_arith_method_FRAME * whatsnew * REF/TYP: use OpsMixin for logical methods (#36964) * TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (#37027) * TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (#37026) Co-authored-by: Rajat Bishnoi <[email protected]> * TYP: generic, series, frame (#36989) * CI: pin pymysql #36465 (#36847) * CI: unpin sql to verify the bugs #36465 * CI: pin sqlalchemy * CI: pin pymsql * CI: pin sqlalchemy * CI: pin pymysql * CI: pin pymysql * CI: add note * CLN/REF: de-duplicate DatetimeTZBlock.setitem (#37019) * REF/TYP: define NDFrame numeric methods non-dynamically (#37017) * CLN: require td64 in TimedeltaBlock (#37018) * BUG: Raise ValueError instead of bare Exception in sanitize_array (#35769) * CLN: collected cleanups, warning suppression in tests (#37021) * REF/TYP: use OpsMixin for DataFrame * CLN: remove get_op_name * mypy fixup * de-privatize Co-authored-by: krajatcl <[email protected]> Co-authored-by: Rajat Bishnoi <[email protected]> Co-authored-by: Fangchen Li <[email protected]> Co-authored-by: Micah Smith <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
* REF/TYP: use OpsMixin for arithmetic methods * REF: separate arith_method_FRAME from flex_arith_method_FRAME * whatsnew * REF/TYP: use OpsMixin for logical methods (pandas-dev#36964) * TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027) * TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026) Co-authored-by: Rajat Bishnoi <[email protected]> * TYP: generic, series, frame (pandas-dev#36989) * CI: pin pymysql pandas-dev#36465 (pandas-dev#36847) * CI: unpin sql to verify the bugs pandas-dev#36465 * CI: pin sqlalchemy * CI: pin pymsql * CI: pin sqlalchemy * CI: pin pymysql * CI: pin pymysql * CI: add note * CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019) * REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017) * CLN: require td64 in TimedeltaBlock (pandas-dev#37018) * BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769) * CLN: collected cleanups, warning suppression in tests (pandas-dev#37021) * REF/TYP: use OpsMixin for DataFrame * CLN: remove get_op_name * mypy fixup * de-privatize Co-authored-by: krajatcl <[email protected]> Co-authored-by: Rajat Bishnoi <[email protected]> Co-authored-by: Fangchen Li <[email protected]> Co-authored-by: Micah Smith <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* REF/TYP: use OpsMixin for arithmetic methods * REF: separate arith_method_FRAME from flex_arith_method_FRAME * whatsnew * REF/TYP: use OpsMixin for logical methods (pandas-dev#36964) * TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027) * TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026) Co-authored-by: Rajat Bishnoi <[email protected]> * TYP: generic, series, frame (pandas-dev#36989) * CI: pin pymysql pandas-dev#36465 (pandas-dev#36847) * CI: unpin sql to verify the bugs pandas-dev#36465 * CI: pin sqlalchemy * CI: pin pymsql * CI: pin sqlalchemy * CI: pin pymysql * CI: pin pymysql * CI: add note * CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019) * REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017) * CLN: require td64 in TimedeltaBlock (pandas-dev#37018) * BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769) * CLN: collected cleanups, warning suppression in tests (pandas-dev#37021) * REF/TYP: use OpsMixin for DataFrame * CLN: remove get_op_name * mypy fixup * de-privatize Co-authored-by: krajatcl <[email protected]> Co-authored-by: Rajat Bishnoi <[email protected]> Co-authored-by: Fangchen Li <[email protected]> Co-authored-by: Micah Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff