CLN: private funcs in concat.py #36726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @ivanovmg generally lgtm pending green and code checks passing.
pandas/core/internals/concat.py
Outdated
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| import pandas.core.algorithms as algos | |||
| from pandas.core.arrays import DatetimeArray, ExtensionArray | |||
| from pandas.core.arrays.sparse.dtype import SparseDtype | |||
There was a problem hiding this comment.
i'm not sure if we have a policy, but in general if the type is imported just for type checking, we normally put in an if TYPE_CHECKING: block. If this is not creating import errors then maybe OK. see what others think.
There was a problem hiding this comment.
@simonjayhawkins, I updated imports as you suggested, so that SparseDtype is used only for type checking.
simonjayhawkins
approved these changes
Sep 29, 2020
mroeschke
approved these changes
Oct 4, 2020
|
Thanks @ivanovmg |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 13, 2020
* REF: extract func _select_upcast_cls_from_dtype * REF: extract function _get_upcast_classes * CLN: rename g -> common_dtype * TYP: type extracted functions * DOC: add docstrings to extracted methods * TYP: cast instead of ignoring mypy error * CLN: import SparseDtype only for type checking
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* REF: extract func _select_upcast_cls_from_dtype * REF: extract function _get_upcast_classes * CLN: rename g -> common_dtype * TYP: type extracted functions * DOC: add docstrings to extracted methods * TYP: cast instead of ignoring mypy error * CLN: import SparseDtype only for type checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffRefactor/cleanup
_get_empty_dtype_and_nainpandas/core/internals/concat.pyExtract functions, add typing.