Skip to content

Single quotes #36896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Single quotes #36896

wants to merge 2 commits into from

Conversation

skorani
Copy link

@skorani skorani commented Oct 5, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel
Copy link
Member

can you merge master

@dsaxton
Copy link
Member

dsaxton commented Oct 5, 2020

Is this identical to #36878?

@MarcoGorelli MarcoGorelli mentioned this pull request Oct 6, 2020
Closed
5 tasks
@MarcoGorelli
Copy link
Member

Thanks @skorani - the task here is to apply blacken-docs, not to find and replace single quotes with double quotes, let us know if you need help

@alimcmaster1
Copy link
Member

@skorani - are you still interested in working on this? Otherwise we can close. Thanks

@dsaxton
Copy link
Member

dsaxton commented Oct 18, 2020

@skorani - are you still interested in working on this? Otherwise we can close. Thanks

The relevant issue here has been closed, so I think safe to close this as well. Thanks anyways @skorani for the PR, there are other good first issues if you wanted to take a look at those.

@dsaxton dsaxton closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skorani @jbrockmendel @dsaxton @MarcoGorelli @alimcmaster1