-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TYP: fix typing errors for mypy==0.790, bump mypy version #37108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6e8bafe
TYP: resolve typing errors for mypy==0.790
fangchenli 21a3605
reformat
fangchenli b9d1784
TYP: ignore type-var error
fangchenli 9a1b946
Merge remote-tracking branch 'upstream/master' into typing-errors
fangchenli 276d927
TYP: ignore operator error
fangchenli 33cc555
fix line length
fangchenli acc47cc
fix line length
fangchenli a1de93e
Merge remote-tracking branch 'upstream/master' into typing-errors
simonjayhawkins 0d0ed94
update
simonjayhawkins fd4489c
Merge remote-tracking branch 'upstream/master' into typing-errors
fangchenli 6e501b3
whatsnew doc
fangchenli e3ffe61
Merge remote-tracking branch 'upstream/master' into typing-errors
fangchenli b0727db
Merge remote-tracking branch 'upstream/master' into typing-errors
fangchenli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -179,7 +179,8 @@ def stringify_path( | |
# this function with convert_file_like=True to infer the compression. | ||
return cast(FileOrBuffer[AnyStr], filepath_or_buffer) | ||
|
||
if isinstance(filepath_or_buffer, os.PathLike): | ||
# Only @runtime_checkable protocols can be used with instance and class checks | ||
if isinstance(filepath_or_buffer, os.PathLike): # type: ignore[misc] | ||
filepath_or_buffer = filepath_or_buffer.__fspath__() | ||
return _expand_user(filepath_or_buffer) | ||
|
||
|
@@ -487,9 +488,15 @@ def infer_compression( | |
if compression in _compression_to_extension: | ||
return compression | ||
|
||
msg = f"Unrecognized compression type: {compression}" | ||
valid = ["infer", None] + sorted(_compression_to_extension) | ||
msg += f"\nValid compression types are {valid}" | ||
# https://github.com/python/mypy/issues/5492 | ||
# Unsupported operand types for + ("List[Optional[str]]" and "List[str]") | ||
valid = ["infer", None] + sorted( | ||
_compression_to_extension | ||
) # type: ignore[operator] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see #37104 (comment) |
||
msg = ( | ||
f"Unrecognized compression type: {compression}\n" | ||
f"Valid compression types are {valid}" | ||
) | ||
raise ValueError(msg) | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #37104 (comment)