Skip to content

Conversation

twoertwein
Copy link
Member

@jreback jreback added Enhancement IO Excel read_excel, to_excel labels Nov 14, 2020
@jreback jreback added this to the 1.2 milestone Nov 14, 2020
@jreback jreback merged commit 3c23e6e into pandas-dev:master Nov 14, 2020
@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

thanks @twoertwein

@twoertwein
Copy link
Member Author

is there a way to re-use documentation? We have blocks about compression storage_options in many places. It would be cool to have them in one place and then import them.

@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

is there a way to re-use documentation? We have blocks about compression storage_options in many places. It would be cool to have them in one place and then import them.

yes for sure, we have the _shared_docs infrastructure, but for excel its prob enough just to use the Appenders

@alimcmaster1
Copy link
Member

Think this broke CI - https://github.com/pandas-dev/pandas/pull/37818/checks?check_run_id=1399068710 - opening up a fix

@twoertwein
Copy link
Member Author

twoertwein commented Nov 14, 2020

oh yes! I think a pytest.importorskip should fix this. @alimcmaster1 Are you already making a PR?

edit: just saw your PR :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants