COMPAT: should an empty string match a format (or just be NaT) #37835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
the
Testing
fgebhart
changed the title
jreback
changed the title
jreback
requested changes
Nov 14, 2020
jreback
reviewed
Nov 14, 2020
|
Seems like the failing tests are not related to my changes - @alimcmaster1 could you please verify? How should I proceed with this issue? Would rebasing on current master help? |
jreback
requested changes
Nov 19, 2020
fgebhart
force-pushed
the
add_test_to_datetime_coerce
branch
from
661e61a to
39fdc4d
Compare
jreback
approved these changes
Nov 19, 2020
|
thanks @fgebhart very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff