TYP: __getitem__ method of EA #37898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
commented
Nov 16, 2020
| def __getitem__(self, key): | ||
| def __getitem__( | ||
| self: NDArrayBackedExtensionArrayT, key: Union[int, slice, np.ndarray] | ||
| ) -> Union[NDArrayBackedExtensionArrayT, Any]: |
There was a problem hiding this comment.
cc @jorisvandenbossche if typevar is not used, mypy gives
pandas\core\arrays\datetimelike.py:280: error: Item "NDArrayBackedExtensionArray" of "Union[NDArrayBackedExtensionArray, Any]" has no attribute "_freq" [union-attr]
simonjayhawkins
added
ExtensionArray
This was referenced Nov 16, 2020
|
lgtm any comments @jbrockmendel @jorisvandenbossche |
| # type (Any) -> Any | ||
| def __getitem__( | ||
| self, item: Union[int, slice, np.ndarray] | ||
| ) -> Union[ExtensionArray, Any]: |
There was a problem hiding this comment.
should ExtensionArray be a typevar here?
There was a problem hiding this comment.
yes it should. Until there is consensus on usage have only added where needed to keep mypy green. see #37898 (comment), #37817 (comment), #31728 (comment), #31384 (comment) and others
|
thanks @simonjayhawkins |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a precursor to #35259 (comment)
there are more changes/additions needed but this PR might get too big to review and push through in a timely manor.
overload is required to avoid casts
Any is used for any type, whereas should use object.
only the abstract classes have been typed.
could create a scalar type alias in each of the EA classes similar to DTScalarOrNaT in DatetimeLikeArrayMixin
import and expose pandas._libs.missing.NAType in pandas._typing
any of these could be done here or as follow-on