BUG: DataFrame.to_html ignores formatters #37958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(GH36525) use self._formatter in ExtensionArrayFormatter._format_strings + pass missing params
added test
arw2019
reviewed
Nov 19, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -654,6 +654,7 @@ I/O | |||
| - :meth:`to_excel` and :meth:`to_markdown` support writing to fsspec URLs such as S3 and Google Cloud Storage (:issue:`33987`) | |||
| - Bug in :meth:`read_fw` was not skipping blank lines (even with ``skip_blank_lines=True``) (:issue:`37758`) | |||
| - :meth:`read_fwf` was inferring compression with ``compression=None`` which was not consistent with the other :meth:``read_*`` functions (:issue:`37909`) | |||
| - :meth:`DataFrame.to_html` was ignoring ``formatters`` on columns of dtype ``ExtensionDtype`` (:issue:`36525`) | |||
There was a problem hiding this comment.
`DataFrame.to_html` was ignoring ``formatter` argument` for ``ExtensionDtype`` columns
jreback
added
IO HTML
|
thanks @ma3da very nice |
arw2019
pushed a commit
to arw2019/pandas
that referenced
this pull request
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff