Skip to content

TST: fix rest of mpl warnings #38659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

TST: fix rest of mpl warnings #38659

merged 1 commit into from
Dec 23, 2020

Conversation

mzeitlin11
Copy link
Member

mzeitlin11
mzeitlin11 commented Dec 23, 2020
View reviewed changes
pandas/tests/plotting/test_hist_method.py
_check_plot_works(self.ts.hist, figure=fig, ax=ax1)
_check_plot_works(self.ts.hist, figure=fig, ax=ax2)
_check_plot_works(self.ts.hist, figure=fig, ax=ax1, default_axes=True)
_check_plot_works(self.ts.hist, figure=fig, ax=ax2, default_axes=True)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default_axes=False was causing plots on additional subplots in addition to the passed ax, redundant with all the existing figure + axis plotting calls already in this method. default_axes=True just makes sure only the passed ax is used.

@mzeitlin11 mzeitlin11 added Warnings Warnings that appear or should be added to pandas Visualization plotting labels Dec 23, 2020
@jreback jreback added this to the 1.3 milestone Dec 23, 2020
@jreback jreback merged commit d388dcf into pandas-dev:master Dec 23, 2020
@jreback
Copy link
Contributor

jreback commented Dec 23, 2020

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the tst/mpl_warnings branch December 23, 2020 19:26
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@mzeitlin11 @luckyvs1
TST: fix rest of mpl warnings (pandas-dev#38659)
801e7c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Visualization plotting Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Fix matplotlib warnings
2 participants
@mzeitlin11 @jreback