Skip to content

CLN: add typing to dtype arg in core/frame.py (GH38808) #39458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

CLN: add typing to dtype arg in core/frame.py (GH38808) #39458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
IndexLabel,
Level,
Manager,
NpDtype,
PythonFuncType,
Renamer,
StorageOptions,
Expand Down Expand Up @@ -1325,7 +1326,9 @@ def __rmatmul__(self, other):
# IO methods (to / from other formats)

@classmethod
def from_dict(cls, data, orient="columns", dtype=None, columns=None) -> DataFrame:
def from_dict(
cls, data, orient="columns", dtype: Optional[Dtype] = None, columns=None
) -> DataFrame:
"""
Construct DataFrame from dict of array-like or dicts.

Expand Down Expand Up @@ -1404,7 +1407,10 @@ def from_dict(cls, data, orient="columns", dtype=None, columns=None) -> DataFram
return cls(data, index=index, columns=columns, dtype=dtype)

def to_numpy(
self, dtype=None, copy: bool = False, na_value=lib.no_default
self,
dtype: Optional[NpDtype] = None,
copy: bool = False,
na_value=lib.no_default,
) -> np.ndarray:
"""
Convert the DataFrame to a NumPy array.
Expand Down