ENH: Styler css Str optional input arguments as well as List[Tuple] #39564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
attack68
commented
Feb 2, 2021
•
attack68
commented
- closes ENH: Styler accepts css-strings input args as well as list of (attr,value) pairs #39563
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
this is ready for review.. |
jreback
requested changes
Feb 4, 2021
pandas/io/formats/style.py
Outdated
|
|
||
| def _maybe_convert_css_to_tuples( | ||
| style: Union[str, Sequence[Tuple[str, Union[str, int, float]]]] | ||
| ): |
There was a problem hiding this comment.
can you add an output type (maybe define this at the top as CSSProperties or similar)
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -56,6 +56,7 @@ Other enhancements | |||
| - :meth:`.Styler.set_tooltips` allows on hover tooltips to be added to styled HTML dataframes. | |||
| - :meth:`Series.loc.__getitem__` and :meth:`Series.loc.__setitem__` with :class:`MultiIndex` now raising helpful error message when indexer has too many dimensions (:issue:`35349`) | |||
| - :meth:`pandas.read_stata` and :class:`StataReader` support reading data from compressed files. | |||
| - :meth:`.Styler.set_tooltips_class` and :meth:`.Styler.set_table_styles` amended to optionally allow certain css-string input arguments. | |||
There was a problem hiding this comment.
locate after the other note, L56 (which is missing an issue number; use the PR number for it)
|
@jreback changes made, with some better typing throughout the module. one failed test is unrelated. |
jreback
approved these changes
Feb 5, 2021
|
thanks @attack68 keep em coming! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.