Skip to content

PERF: special case numpy.dtype in is_extension_array_dtype #39678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion asv_bench/benchmarks/dtypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

import numpy as np

import pandas as pd
from pandas import DataFrame
import pandas._testing as tm
from pandas.api.types import pandas_dtype
from pandas.api.types import is_extension_array_dtype, pandas_dtype

from .pandas_vb_common import (
datetime_dtypes,
Expand Down Expand Up @@ -119,4 +120,16 @@ def time_select_dtype_string_exclude(self, dtype):
self.df_string.select_dtypes(exclude=dtype)


class CheckDtypes:
def setup(self):
self.ext_dtype = pd.Int64Dtype()
self.np_dtype = np.dtype("int64")

def time_is_extension_array_dtype_true(self):
is_extension_array_dtype(self.ext_dtype)

def time_is_extension_array_dtype_false(self):
is_extension_array_dtype(self.np_dtype)


from .pandas_vb_common import setup # noqa: F401 isort:skip
7 changes: 6 additions & 1 deletion pandas/core/dtypes/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,12 @@ def is_extension_array_dtype(arr_or_dtype) -> bool:
False
"""
dtype = getattr(arr_or_dtype, "dtype", arr_or_dtype)
return isinstance(dtype, ExtensionDtype) or registry.find(dtype) is not None
if isinstance(dtype, ExtensionDtype):
return True
elif isinstance(dtype, np.dtype):
return False
else:
return registry.find(dtype) is not None


def is_ea_or_datetimelike_dtype(dtype: Optional[DtypeObj]) -> bool:
Expand Down