Skip to content

REF: separate out indexer/mask preprocessing code in algorithms.take_nd #39728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

REF: separate out indexer/mask preprocessing code in algorithms.take_nd #39728

merged 1 commit into from
Feb 10, 2021

Conversation

jorisvandenbossche
Copy link
Member

Precursor for #39692 (just moving code into a separate helper function)

@jorisvandenbossche jorisvandenbossche mentioned this pull request Feb 10, 2021
Merged
@jbrockmendel
Copy link
Member

FWIW im thinking a lot of take code could go into an array_algos.take

@jreback jreback added this to the 1.3 milestone Feb 10, 2021
@jreback jreback added the Refactor Internal refactoring of code label Feb 10, 2021
@jreback jreback merged commit 2b490df into pandas-dev:master Feb 10, 2021
@jreback
Copy link
Contributor

jreback commented Feb 10, 2021

thanks. yeah array_alogs.take sgtm.

@jorisvandenbossche jorisvandenbossche deleted the perf-take-precursor branch February 10, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @jbrockmendel @jreback