Skip to content

REF: consolidate paths for astype #39900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2021
Merged

REF: consolidate paths for astype #39900

merged 3 commits into from
Feb 19, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback requested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase & is the added code covered?

@jbrockmendel
Copy link
Member Author

is the added code covered?

yes. this is broken off from a branch that makes DTBlock/TDBlock directly backed by DTA/TDA; these are edits needed to make that pass

@jreback jreback added the Refactor Internal refactoring of code label Feb 19, 2021
@jreback jreback added this to the 1.3 milestone Feb 19, 2021
@jreback jreback merged commit f904213 into pandas-dev:master Feb 19, 2021
@jbrockmendel jbrockmendel deleted the prelim-hybrid branch February 19, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback