Skip to content

BENCH: collect isin asvs #39922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2021
Merged

BENCH: collect isin asvs #39922

merged 5 commits into from
Feb 21, 2021

Conversation

jbrockmendel
Copy link
Member

Pushes these as far towards parametrization as I can get them. We end up adding a few cases, dropping none.

Decides on a policy to benchmark Series.isin and leave the others alone (see algos/__init__.py)

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Feb 21, 2021
@jreback jreback added this to the 1.3 milestone Feb 21, 2021
@jreback jreback merged commit 8051248 into pandas-dev:master Feb 21, 2021
@jreback
Copy link
Contributor

jreback commented Feb 21, 2021

great. nice to collect these. only concern is that these are kept to a reasonable amount of time (more of a general concern about benchmarks).

@jbrockmendel jbrockmendel deleted the asvs-isin branch February 21, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants