Skip to content

STYLE: inconsistent namespace (io, reshape) #40069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

STYLE: inconsistent namespace (io, reshape) #40069

merged 1 commit into from
Feb 26, 2021

Conversation

AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented Feb 25, 2021 •
edited
Loading

@AA-Turner
Copy link
Contributor Author

@MarcoGorelli this is io and reshape. First time contributing to pandas so let me know if there are any style things I should change - I read over the dev docs and think I've got everything.

Thanks!

@jreback jreback added the Code Style Code style, linting, code_checks label Feb 26, 2021
@jreback
Copy link
Contributor

jreback commented Feb 26, 2021

can you merge master

@AA-Turner AA-Turner force-pushed the inconsistent-namespace branch from 850c045 to 8ea4fc2 Compare February 26, 2021 02:52
@AA-Turner
Copy link
Contributor Author

Rebased & pushed

@MarcoGorelli
Copy link
Member

Hi @AA-Turner - reshape is already covered by #40058, could you revert those changes and just keep this to io please?

@AA-Turner
Copy link
Contributor Author

Thanks Marco, mutst've missed that when I was looking for what had been done already. Will do as you ask

@AA-Turner AA-Turner force-pushed the inconsistent-namespace branch from 8ea4fc2 to 3048a86 Compare February 26, 2021 18:57
@AA-Turner
Copy link
Contributor Author

Done

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Feb 26, 2021
@MarcoGorelli MarcoGorelli merged commit fc4d3f2 into pandas-dev:master Feb 26, 2021
@MarcoGorelli
Copy link
Member

Thanks @AA-Turner !

@rhshadrach
Copy link
Member

Looks like this PR had some failure - seeing them on master as well now. Are these related?

@AA-Turner
Copy link
Contributor Author

AA-Turner commented Feb 26, 2021 •
edited
Loading

Hi Richard - will look into this. Given this just changes namespace usage, may be that pandas/__init__.py exposes names or something that aren't in submodules.

Edit: found the cause, see below

Given a lot of tests/CI checks failed - is there a known subset that are ingored? I'll look for io related tests in the logs first, though.

@AA-Turner AA-Turner mentioned this pull request Feb 26, 2021
Merged
3 tasks
@AA-Turner
Copy link
Contributor Author

AA-Turner commented Feb 26, 2021 •
edited
Loading

Found three failures I think are related - all in test_stata.py. The changes moved to using io.stata.blah (stripping the leading pd.), which shadows the io builtin, and I didn't catch when looking over.

PR to fix is at #40094

Adam

@AA-Turner AA-Turner deleted the inconsistent-namespace branch February 26, 2021 22:36
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 27, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AA-Turner @jreback @MarcoGorelli @rhshadrach