Skip to content

CLN: Remove _axis from apply #40261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

CLN: Remove _axis from apply #40261

merged 1 commit into from
Mar 8, 2021

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Mar 5, 2021 •
edited
Loading

  • Ensure all linting tests pass, see here for how to run them

The regex [\W]_axis is showing this removes the only occurances of the variable _axis throughout all of pandas.core. It is only set in groupby in a branch where is must be 0, and is only used to check that it is 0.

@rhshadrach rhshadrach added Clean Apply Apply, Aggregate, Transform, Map labels Mar 5, 2021
@jreback jreback added this to the 1.3 milestone Mar 8, 2021
@jreback jreback merged commit 8c62fbb into pandas-dev:master Mar 8, 2021
@jreback
Copy link
Contributor

jreback commented Mar 8, 2021

thanks @rhshadrach

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 11, 2021
@rhshadrach @jbrockmendel
CLN: Remove _axis from apply (pandas-dev#40261)
bf5aa60
@rhshadrach rhshadrach deleted the remove_axis branch October 19, 2021 03:45
@simonjayhawkins simonjayhawkins mentioned this pull request May 4, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Clean
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @jreback