Skip to content

CI: avoid port-already-in-use errors #40282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021
Merged

CI: avoid port-already-in-use errors #40282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions pandas/tests/io/test_user_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,39 +179,40 @@ def do_GET(self):


@pytest.mark.parametrize(
"responder, read_method, port, parquet_engine",
"responder, read_method, parquet_engine",
[
(CSVUserAgentResponder, pd.read_csv, 34259, None),
(CSVUserAgentResponder, pd.read_csv, None),
pytest.param(
JSONUserAgentResponder,
pd.read_json,
34260,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, 34261, "pyarrow"),
(ParquetFastParquetUserAgentResponder, pd.read_parquet, 34262, "fastparquet"),
(PickleUserAgentResponder, pd.read_pickle, 34263, None),
(StataUserAgentResponder, pd.read_stata, 34264, None),
(GzippedCSVUserAgentResponder, pd.read_csv, 34265, None),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, "pyarrow"),
(ParquetFastParquetUserAgentResponder, pd.read_parquet, "fastparquet"),
(PickleUserAgentResponder, pd.read_pickle, None),
(StataUserAgentResponder, pd.read_stata, None),
(GzippedCSVUserAgentResponder, pd.read_csv, None),
pytest.param(
GzippedJSONUserAgentResponder,
pd.read_json,
34266,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
],
)
def test_server_and_default_headers(responder, read_method, port, parquet_engine):
def test_server_and_default_headers(responder, read_method, parquet_engine):
if parquet_engine is not None:
pytest.importorskip(parquet_engine)
if parquet_engine == "fastparquet":
pytest.importorskip("fsspec")

with http.server.HTTPServer(("localhost", port), responder) as server:
# passing 0 for the port will let the system find an unused port
with http.server.HTTPServer(("localhost", 0), responder) as server:
server_thread = threading.Thread(target=server.serve_forever)
server_thread.start()

port = server.server_port
if parquet_engine is None:
df_http = read_method(f"http://localhost:{port}")
else:
Expand All @@ -223,42 +224,43 @@ def test_server_and_default_headers(responder, read_method, port, parquet_engine


@pytest.mark.parametrize(
"responder, read_method, port, parquet_engine",
"responder, read_method, parquet_engine",
[
(CSVUserAgentResponder, pd.read_csv, 34267, None),
(CSVUserAgentResponder, pd.read_csv, None),
pytest.param(
JSONUserAgentResponder,
pd.read_json,
34268,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, 34269, "pyarrow"),
(ParquetFastParquetUserAgentResponder, pd.read_parquet, 34270, "fastparquet"),
(PickleUserAgentResponder, pd.read_pickle, 34271, None),
(StataUserAgentResponder, pd.read_stata, 34272, None),
(GzippedCSVUserAgentResponder, pd.read_csv, 34273, None),
(ParquetPyArrowUserAgentResponder, pd.read_parquet, "pyarrow"),
(ParquetFastParquetUserAgentResponder, pd.read_parquet, "fastparquet"),
(PickleUserAgentResponder, pd.read_pickle, None),
(StataUserAgentResponder, pd.read_stata, None),
(GzippedCSVUserAgentResponder, pd.read_csv, None),
pytest.param(
GzippedJSONUserAgentResponder,
pd.read_json,
34274,
None,
marks=td.skip_array_manager_not_yet_implemented,
),
],
)
def test_server_and_custom_headers(responder, read_method, port, parquet_engine):
def test_server_and_custom_headers(responder, read_method, parquet_engine):
if parquet_engine is not None:
pytest.importorskip(parquet_engine)
if parquet_engine == "fastparquet":
pytest.importorskip("fsspec")

custom_user_agent = "Super Cool One"
df_true = pd.DataFrame({"header": [custom_user_agent]})
with http.server.HTTPServer(("localhost", port), responder) as server:

# passing 0 for the port will let the system find an unused port
with http.server.HTTPServer(("localhost", 0), responder) as server:
server_thread = threading.Thread(target=server.serve_forever)
server_thread.start()

port = server.server_port
if parquet_engine is None:
df_http = read_method(
f"http://localhost:{port}",
Expand All @@ -279,22 +281,25 @@ def test_server_and_custom_headers(responder, read_method, port, parquet_engine)


@pytest.mark.parametrize(
"responder, read_method, port",
"responder, read_method",
[
(AllHeaderCSVResponder, pd.read_csv, 34275),
(AllHeaderCSVResponder, pd.read_csv),
],
)
def test_server_and_all_custom_headers(responder, read_method, port):
def test_server_and_all_custom_headers(responder, read_method):
custom_user_agent = "Super Cool One"
custom_auth_token = "Super Secret One"
storage_options = {
"User-Agent": custom_user_agent,
"Auth": custom_auth_token,
}
with http.server.HTTPServer(("localhost", port), responder) as server:

# passing 0 for the port will let the system find an unused port
with http.server.HTTPServer(("localhost", 0), responder) as server:
server_thread = threading.Thread(target=server.serve_forever)
server_thread.start()

port = server.server_port
df_http = read_method(
f"http://localhost:{port}",
storage_options=storage_options,
Expand Down