API: remove .set_tooltips_class incorpate to .set_tooltips
#40284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
commented
Mar 7, 2021
| """ | ||
| Checks parameters compatible with tooltips and creates instance if necessary | ||
| """ | ||
| if not self.cell_ids: |
There was a problem hiding this comment.
this code is moved inside the set_tooltips method
|
thanks @attack68 very nice |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.set_tooltipsand.set_tooltips_classare introduced to 1.3.0.Just realised it seems a bit pointless to have two api functions:
.set_tooltips_class()and._init_tooltips()css_nameandpropsarguments in.set_tooltipsfor same functionality.