REF/TYP: indexes #40330
Merged
REF/TYP: indexes #40330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Mar 9, 2021
| except (KeyError, TypeError, ValueError): | ||
| return False | ||
| return bool( | ||
| is_scalar(res) or isinstance(res, slice) or (is_list_like(res) and len(res)) |
There was a problem hiding this comment.
this is some crazy condition, good to remove it
jreback
added
Index
what kind of gains here? |
|
hmm, the azure checks are not running. odd |
on the benchmark ive been using, _reset_identity is about 2.4% of the runtime, which this cuts to 1% |
|
thanks @jbrockmendel |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-trivial change here is changing
_idfrom_id = _Identity(object)to_id = object(), which I found in profiling (#40171 (comment)) makes a non-trivial difference as the non-cython performance inches closer to the cython performance.Share DTI/TDI/PI's _simple_new with Categorical.
Simplify DTI/TDI
__contains__Annotations.
Docstring follow-up to #40241