Skip to content

⬆️ UPGRADE: Autoupdate pre-commit config #41992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

github-actions[bot]
Copy link
Contributor

Base PullRequest

default branch (https://github.com/pandas-dev/pandas/tree/master)

Command results

Details:

Changed files

Changed file:

:octocat: Repo | 📝 Issues | 🏬 Marketplace

@MarcoGorelli
Copy link
Member

putting this off for now

@simonjayhawkins
Copy link
Member

putting this off for now

This is not already done? #38376

@MarcoGorelli
Copy link
Member

yeah not sure why it wasn't picked up here

@simonjayhawkins
Copy link
Member

The isort is also upgraded. If that make significant changes, maybe worth doing so that we can backport now while 1.3.x and master are not significantly diverged so that we can reduce the potentially reduce failures on autobackports in the future.

@simonjayhawkins
Copy link
Member

a quick scan of the diff. didn't notice any changes to imports.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jun 14, 2021

The isort is also upgraded. If that make significant changes, maybe worth doing so that we can backport now while 1.3.x and master are not significantly diverged so that we can reduce the potentially reduce failures on autobackports in the future.

in this PR it's pyupgrade that's updated, but the change is really minor, isort is still at 5.8.0


Maybe I need to delete the branch for this to work properly, will try now

@MarcoGorelli MarcoGorelli deleted the create-pr-action/pre-commit-config-update-0 branch June 14, 2021 09:16
@simonjayhawkins
Copy link
Member

in this PR it's pyupgrade that's updated, but the change is really minor, isort is still at 5.8.0

thanks @MarcoGorelli misread the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants