ENH: Clarify error message when reindexing fails (#42000) #42007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aberres
commented
Jun 14, 2021
•
aberres
commented
- closes ENH: Clarify error message when reindexing on an axis containing duplicates #42000
- Ensure all linting tests pass, see here for how to run them
pandas/core/indexes/base.py
Outdated
| @@ -3708,7 +3708,7 @@ def _validate_can_reindex(self, indexer: np.ndarray) -> None: | |||
| """ | |||
| # trying to reindex on an axis with duplicates | |||
| if not self._index_as_unique and len(indexer): | |||
| raise ValueError("cannot reindex from a duplicate axis") | |||
| raise ValueError("Cannot reindex on an axis with duplicate labels") | |||
There was a problem hiding this comment.
I think it's common practice not to use capitalization
SyntaxError: invalid syntax
IndexError: list index out of range
IndentationError: unexpected indent
IndentationError: expected an indented block
There was a problem hiding this comment.
agree. @aberres can you update & ping on green.
jreback
requested changes
Jun 15, 2021
pandas/core/indexes/base.py
Outdated
| @@ -3708,7 +3708,7 @@ def _validate_can_reindex(self, indexer: np.ndarray) -> None: | |||
| """ | |||
| # trying to reindex on an axis with duplicates | |||
| if not self._index_as_unique and len(indexer): | |||
| raise ValueError("cannot reindex from a duplicate axis") | |||
| raise ValueError("Cannot reindex on an axis with duplicate labels") | |||
There was a problem hiding this comment.
agree. @aberres can you update & ping on green.
|
@jreback Updated. Not green, but the failing check seems unrelated? |
should now be fixed |
|
i'll merge with a 1.4 milestone. but a trivial change so could backport. |
|
Thanks @aberres |
iynehz
pushed a commit
to iynehz/pandas
that referenced
this pull request
Jun 20, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.