TST: raising ValueError when inserting one dataframe in another #42831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debnathshoham
commented
Jul 31, 2021
debnathshoham
commented
- closes BUG: DafaFrame.insert doesn't raise an exception when inserting another DataFrame #42403
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
phofl
requested changes
Jul 31, 2021
| @@ -89,3 +89,10 @@ def test_insert_item_cache(self, using_array_manager): | |||
| ser.values[0] = 99 | |||
|
|
|||
| assert df.iloc[0, 0] == df[0][0] | |||
|
|
|||
| def test_insert_frame(self): | |||
There was a problem hiding this comment.
Very confused. I am getting a seperate error message on my local.
There was a problem hiding this comment.
The ci error is correct, you will have to debug locally why it is not raised for you
There was a problem hiding this comment.
changed the error msg, but this is also failing. Would need some help, how same error raises multiple error msgs
|
Hello @debnathshoham! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-04 17:14:31 UTC |
jreback
added
Indexing
phofl
approved these changes
Aug 5, 2021
|
Thanks @debnathshoham |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…as-dev#42831) * TST: raising ValueError when inserting one dataframe in another * added GH issue reference * rev msg * included both msgs * updated * Update test_insert.py * Update test_insert.py * Update test_insert.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.