Skip to content

REF: pre-compute JoinUnit.needs_filling #43590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

REF: pre-compute JoinUnit.needs_filling #43590

merged 2 commits into from
Sep 16, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

can you rebase

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Sep 16, 2021
@jreback jreback added this to the 1.4 milestone Sep 16, 2021
@jreback jreback merged commit 7036de3 into pandas-dev:master Sep 16, 2021
@jbrockmendel jbrockmendel deleted the ref-unit-dtype branch September 16, 2021 21:30
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Jun 15, 2022
@jorisvandenbossche
Revert "REF: pre-compute JoinUnit.needs_filling (pandas-dev#43590)"
e785ff6 
This reverts commit 7036de3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback