Skip to content

REF: de-duplicate MaskedArray tests #44004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2021
Merged

REF: de-duplicate MaskedArray tests #44004

merged 2 commits into from
Oct 13, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@alimcmaster1 alimcmaster1 added the Testing pandas testing functions or related to the test suite label Oct 12, 2021
@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Oct 12, 2021
alimcmaster1
alimcmaster1 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up - LGTM

@mzeitlin11 mzeitlin11 added ExtensionArray Extending pandas with custom dtypes or arrays. NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Oct 13, 2021
@mzeitlin11 mzeitlin11 merged commit 22de58e into pandas-dev:master Oct 13, 2021
@jbrockmendel jbrockmendel deleted the bug-_compare_other branch October 13, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

+1 more reviewer

@mzeitlin11 mzeitlin11 mzeitlin11 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. NA - MaskedArrays Related to pd.NA and nullable extension arrays Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @alimcmaster1 @mzeitlin11