Tests added for dtype comparison with fixture #44840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we stick to the original PR please? rebasing is a fundamental part of the git workflow, it's worth learning |
2 tasks
|
@MarcoGorelli My latest commit passed all the tests except one because of this code: FAILED pandas/tests/io/parser/test_c_parser_only.py::test_buffer_rd_bytes[c_low] This is not a test I wrote, so what can i do about it? Thank you. |
|
it's unrelated, don't worry about it |
@MarcoGorelli Do i need to do anything else before merge? |
jreback
added
Dtype Conversions
|
thanks @fotino21 |
|
Thanks for all of you. I am grateful for this experience ;] @jreback @MarcoGorelli |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int64withInt64fails #43038 closes #xxxxFirstly, this is my first contribution to a huge code base therefore I am learning everything the first time, sorry for this inconvenience, again. Secondly, I have another pr for this commit but it involved a lot of other changes (315 file change) by other people and I dont know what to do with those changes. So I made this pr to make my one file change merge to master branch. If you can merge it to master before Sunday, I will be very happy because I need it for my class project. Thank you and kind regards.
My another pull who had 315 file change by other people: #44618